Discussion:
File#directory? docs
Ilkka Laukkanen
2010-05-01 18:14:53 UTC
Permalink
Hi,

I just noticed for the first time that if you have a symlink, say
"foo", that points at a directory, both

File.symlink? 'foo'

and

File.directory? 'foo'

return true. While this is a bit misleading in my opinion, it should
definitely be documented in File.directory?. So here's a tiny little
patch against trunk that documents this caveat in File#directory?.
What do you think?
--
Ilkka
Arif Jafer
2010-05-02 09:08:13 UTC
Permalink
Sorry I didn't recognize neithor you nor i didn't understood your e-mail.

Your sincerely
Arif Jafer
Post by Ilkka Laukkanen
Hi,
I just noticed for the first time that if you have a symlink, say
"foo", that points at a directory, both
File.symlink? 'foo'
and
File.directory? 'foo'
return true. While this is a bit misleading in my opinion, it should
definitely be documented in File.directory?. So here's a tiny little
patch against trunk that documents this caveat in File#directory?.
What do you think?
--
Ilkka
Roger Pack
2010-05-04 17:58:18 UTC
Permalink
Sure submit a patch to redmine.ruby-lang.org

On Sat, May 1, 2010 at 12:14 PM, Ilkka Laukkanen
Post by Ilkka Laukkanen
Hi,
I just noticed for the first time that if you have a symlink, say
"foo", that points at a directory, both
 File.symlink? 'foo'
and
 File.directory? 'foo'
return true. While this is a bit misleading in my opinion, it should
definitely be documented in File.directory?. So here's a tiny little
patch against trunk that documents this caveat in File#directory?.
What do you think?
--
Ilkka
Ted Behling
2010-05-04 18:21:32 UTC
Permalink
Roger -- I will probably have some doc patches to contribute at some point -- is Redmine the preferred way to accept patches?

-----Original Message-----
From: Roger Pack [mailto:***@gmail.com]
Sent: Tuesday, May 04, 2010 1:58 PM
To: ruby-***@ruby-lang.org
Subject: Re: File#directory? docs

Sure submit a patch to redmine.ruby-lang.org
Post by Ilkka Laukkanen
Hi,
I just noticed for the first time that if you have a symlink, say
"foo", that points at a directory, both
 File.symlink? 'foo'
and
 File.directory? 'foo'
return true. While this is a bit misleading in my opinion, it should
definitely be documented in File.directory?. So here's a tiny little
patch against trunk that documents this caveat in File#directory?.
What do you think?
--
Ilkka
Roger Pack
2010-05-05 16:22:30 UTC
Permalink
Post by Ted Behling
Roger -- I will probably have some doc patches to contribute at some point -- is Redmine the preferred way to accept patches?
Yeah. They get merged in...typically quickly (not by me, but by other
maintainers).
I haven't had one that wasn't eventually merged (though some weren't fast).
-rp

Ilkka Laukkanen
2010-05-05 09:08:17 UTC
Permalink
Post by Roger Pack
Sure submit a patch to redmine.ruby-lang.org
This is now bug #3249: http://redmine.ruby-lang.org/issues/show/3249
--
Ilkka
Loading...